Skip to content

Conversation

@lehni
Copy link
Collaborator

@lehni lehni commented Jul 21, 2023

It reached EOL in April 2022

It reached EOL in April 2022
@lehni lehni merged commit 848fd2b into master Jul 21, 2023
@lehni lehni deleted the feature/drop-node-12 branch July 21, 2023 09:12
@tafel
Copy link

tafel commented Jul 21, 2023

This is a breaking change, no? Maybe a version number bumped to 4 would have been nice.

@lehni
Copy link
Collaborator Author

lehni commented Jul 21, 2023

I don't think this rectifies a bump to v4. I did minor increase, just like typescript did to v5.1 where they also stopped supporting Node 12: https://devblogs.microsoft.com/typescript/announcing-typescript-5-1/

@tafel
Copy link

tafel commented Jul 24, 2023

Just wondering if you were stuck on node 12 for some reasons, npm upgrade would fail trying to install the new version (which needs node >=14). But it is not my case, and maybe npm is smart enough to not throw an error in this case, and keep the old version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants