Include ajv-formats by default #2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lehni
force-pushed
the
feature/include-ajv-formats
branch
from
adc845d to
15e677b
Compare
Collaborator
Author
|
Released in v3.0.5 |
|
Perhaps it would have been better to mark this as a breaking change. All people already including ajv-format in a custom extended Model will have now an error "Keyword {somekeyword} is already defined". |
Collaborator
Author
|
Ouch, I didn't realize this could happen, my bad. Are you using the |
Collaborator
Author
|
Also, I can roll out a 3.0.6 with this fix in and Node 12 compatibility, if it's of interest. |
Collaborator
Author
|
Fix released in v3.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2218, #2142, #2146, #2147, #2170