fix: losing aliasMap in 'partial' subqueries #2405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue with 'partial' suibqueries that they lose `aliasMap` from `q._context` (QueryBuilder's "internal context") while generating nested `where` sql part. `QueryBuilder.subqueryOf()` used to grab context from "parent" query, but it doesn't anymore. (since 2019-02-13) Vincit@524e0be Basically reintroducing what was deleted in Vincit@524e0be but wrap merging context with a condition that it should only apply to "partial" subqueries + reverse the sequence that `isPartial()` is set before `subqueryOf()`
glensc
reviewed
Apr 23, 2023
Co-authored-by: Elan Ruusamäe <[email protected]>
Collaborator
|
@falkenhawk great thanks! this looks reasonable. Adding a test would be good to prevent a future regression? |
with error: `no such column: model2.model2_prop2`
Contributor
Author
|
@lehni I've added a test which fails with on the master branch. Perhaps the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from ovos#13
This fixes an issue with 'partial' subqueries that they lose
aliasMapfromq._context(QueryBuilder's "internal context") while generating nestedwheresql part.QueryBuilder.subqueryOf()used to grab context from "parent" query, but it doesn't anymore. (since 2019-02-13) 524e0beIn our case, we were getting SQL errors where alias was necessary to make it work, but it was missing
Basically reintroducing what was deleted in 524e0be (to fix #1205) but wrap merging context with a condition that it should only apply to "partial" subqueries + reverse the sequence that
isPartial()is set beforesubqueryOf()