fix typings for PartialModelGraph and nullable fields #2404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle `| null` unions properly. (e.g. for nullable `BelongsToOneRelations`). Before `PartialModelGraph` was converting `field: Model | null;` to `field?: Expression<Model | null>`, and typescript throws errors for graphs with partial sub-graphs for those nullable relations. (expecting full instance of the model class) Now it converts it properly to `field?: PartialModelGraph<Model> | null` 🎉
falkenhawk
force-pushed
the
fix-typings-for-graphs-with-nullable-fields
branch
from
479a03d to
69a172c
Compare
…d relations when the type of relation's field is defined as nullable with `| null`.
Collaborator
|
LGTM, thanks @falkenhawk ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from ovos#16 and adjusted for a typescript perf workaround which landed in 2cefc77
Handle
| nullunions properly. (e.g. for nullableBelongsToOneRelations).Before
PartialModelGraphwas convertingfield: Model | null;tofield?: Expression<Model | null>, and typescript throws errors for graphs with partial sub-graphs for those nullable relations. (expecting full instance of the model class)Now it converts it properly to
field?: PartialModelGraph<Model> | null🎉fixes the issue mentioned in the last paragraph of the #1774 (comment) by @jeremy-w