Typings: Add knex() method type to QueryBuilder #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pigpudle
changed the title
Collaborator
|
Looks good, thank you @pigpudle! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objection.js allows us to get Knex instance from QueryBuilder by using
.knex()method like this:Source code: https://github.com/Vincit/objection.js/blob/master/lib/queryBuilder/QueryBuilderOperationSupport.js#L194
But this method is not defined in types definitions. Thus TypeScript shows an error like
Property 'knex' does not exist on type 'QueryBuilder<ModelName, ModelName[]>'when using the above code.This PR adds
.knex()method definition to QueryBuilder types.