Update WhereIN TS-defs to use readonly primitive arrays #2274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@koskimas lmk if you have any questions or qualms here! |
Contributor
Author
|
@koskimas Any way we can get this change in and released? Would be really helpful for typesafe code and should not be functionality impacting so low-risk |
Contributor
Author
|
@kibertoad wanted to flag this as a (hopefully) simple TS def fix for a potential minor version release! |
Contributor
Author
|
@falkenhawk are you the new maintainer? Trying to get this picked up for a future build at some point! |
Contributor
|
I'm not, currently @kibertoad is |
Collaborator
|
@comp615 this look good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because doing something like:
will not modify
myArray, if we mark the TS-type as ReadOnly, it makes the type more accessible for a variety of use-cases (i.e. readonly arrays can be passed in). Note that mutable arrays can still be cast into read only so this is "backwards compatible" type-wise.Fixes #2271