Skip to content

Adding ajv-formats package #2218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TigerC10 wants to merge 1 commit into from
Closed

Adding ajv-formats package #2218

TigerC10 wants to merge 1 commit into from

Conversation

@TigerC10
Copy link

@TigerC10 TigerC10 commented Feb 6, 2022

Adding the ajv-formats package so people stop complaining about missing date formats.
Solves #2142, #2146, #2147, #2170

@paulbjensen paulbjensen mentioned this pull request Feb 14, 2022
Closed
@LordA98
Copy link

LordA98 commented Oct 12, 2022

Hi, just wondered if there was any chance of getting this reviewed and merged?

@vichle
Copy link

vichle commented Jan 26, 2023

@kibertoad Sorry to bother you, I get that you have a lot on your plate, but I saw you have approved and merged other changes.

This is a fix for an undocumented breaking change that has been in limbo for almost a year, it would be very appreciated if it could be reviewed and merged 🙏

Sorry for pinging you ❤️

@lehni lehni mentioned this pull request Apr 15, 2023
Open
@lehni
Copy link
Collaborator

lehni commented Apr 15, 2023 •
edited
Loading

The code is a bit convoluted. Since the PR adds ajv-formats as a dependency, the require checks in getAjvFormats() aren't needed at all. It can just be imported normally.

If the dependency was optional, then the check would be useful…

@falkenhawk
Copy link
Contributor

falkenhawk commented Apr 17, 2023 •
edited
Loading

I agree, it should be a normal, direct dependency. Ajv used to include formats, but they extracted them to a separate package, starting from v7. re: #2146 (comment)

lehni added a commit that referenced this pull request Jul 5, 2023
@lehni
Include ajv-formats by default
adc845d 
Closes #2218, #2142, #2146, #2147, #2170
@lehni lehni mentioned this pull request Jul 5, 2023
Merged
lehni added a commit that referenced this pull request Jul 5, 2023
@lehni
Include ajv-formats by default
15e677b 
Closes #2218, #2142, #2146, #2147, #2170
@lehni lehni closed this in #2453 Jul 5, 2023
lehni added a commit that referenced this pull request Jul 5, 2023
@lehni
Include ajv-formats by default (#2453)
6b5b300 
Closes #2218, #2142, #2146, #2147, #2170
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@TigerC10 @LordA98 @vichle @lehni @falkenhawk