Skip to content

Conversation

@brianmcd
Copy link
Contributor

Fixes #1676

@brianmcd brianmcd force-pushed the configure-mapper-underscore branch from ca1433e to 927ad1a Compare February 12, 2020 17:16
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 97.076% when pulling 927ad1a on brianmcd:configure-mapper-underscore into 5b76a4c on Vincit:master.

@coveralls
Copy link

coveralls commented Feb 12, 2020

Coverage Status

Coverage increased (+0.003%) to 97.076% when pulling 927ad1a on brianmcd:configure-mapper-underscore into 5b76a4c on Vincit:master.

@koskimas
Copy link
Collaborator

Thank you! Clean implementation and good tests! Wish I got more of these 💯

@koskimas koskimas merged commit e646635 into Vincit:master Feb 12, 2020
@brianmcd brianmcd deleted the configure-mapper-underscore branch February 12, 2020 21:10
@brianmcd
Copy link
Contributor Author

brianmcd commented Feb 12, 2020

Thanks for the quick merge! The up-to-date dev setup instructions, docker containers, and extensive test suite made it really easy to contribute.

@koskimas
Copy link
Collaborator

This still needs documentation and typescript typings. I can do that, but I'm currently quite busy with my work so it will be a while. If you have more time, I'd be more than happy about a PR for those too.

@brianmcd
Copy link
Contributor Author

Sure! I'm happy to make those updates. I think docs are missing for the underscoreBeforeDigits option, so I'll add those, too.

Are the relevant pages here and here?

For the TypeScript typings, I added the property here in this PR. Is there another place I need to add it, or are we good on that part?

@koskimas
Copy link
Collaborator

Oh sorry I missed the typing change in your PR. That's it for those 👍 And yep, those are the relevant pages. I'll release a new version as soon as the docs are updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: make knexSnakeCaseMappers behavior with multiple consecutive uppercase letters configurable

3 participants