-
Notifications
You must be signed in to change notification settings - Fork 642
Description
EDIT BY @koskimas: This has been fixed in 1.1.3
Seems to be a regression in 1.1.2.
When calling JSON.stringify(entities); (which, e. g., happens when you are trying to send an array of Objection entities as a response from Express), an error is thrown.
Error seems to only manifest itself when entity in question has custom idColumn defined (in this particular case it was defined as
static get idColumn() {
return 'key';
}
)
Error stacktrace:
TypeError: Cannot use 'in' operator to search for 'key' in undefined
at assignJsonValue (C:\sources\lms-api\models\node_modules\objection\lib\model\modelToJson.js:79:33)
at toExternalJsonImpl (C:\sources\lms-api\models\node_modules\objection\lib\model\modelToJson.js:51:5)
at toJson (C:\sources\lms-api\models\node_modules\objection\lib\model\modelToJson.js:20:14)
at Brand.$toJson (C:\sources\lms-api\models\node_modules\objection\lib\model\Model.js:204:12)
at Brand.toJSON (C:\sources\lms-api\models\node_modules\objection\lib\model\Model.js:208:17)
at JSON.stringify ()
at eval (eval at stringify (C:\sources\lms-api\api\node_modules\express\lib\response.js:1117:14), :1:6)
at stringify (C:\sources\lms-api\api\node_modules\express\lib\response.js:1117:14)
at ServerResponse.json (C:\sources\lms-api\api\node_modules\express\lib\response.js:260:14)
at ServerResponse.send (C:\sources\lms-api\api\node_modules\express\lib\response.js:158:21)
at router.get (C:\sources\lms-api\api\controllers\brands.controller.js:44:7)
at
Surprisingly, this works fine when single entity is being stringified.