Skip to content

merge() doesn't seem to use model hooks #1964

@willsoto

Description

@willsoto

Thanks for adding onConflict(), it's a great addition.

One thing I noticed was that merge() doesn't seem to "process" the object in the same way insert, patch, etc do. As a simple example, columnNameMappers - like snakeCaseMappers - don't seem to be getting applied. Same for things like $parseJson as far as I can tell. Since merge can accept an optional record to update in the case of a conflict, I'd expect that record to be processed using the same hooks as insert, patch, etc

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions