Skip to content

v2 .offset & .limit typings denote return type as wrapped in a Page #1585

New issue
New issue
Closed
Closed
v2 .offset & .limit typings denote return type as wrapped in a Page#1585
@mastermatt

Description

@mastermatt
mastermatt
opened on Dec 2, 2019

objection.js/typings/objection/index.d.ts

Lines 715 to 721 in f68fc6b

interface OffsetMethod<QB extends AnyQueryBuilder> {
(offset: number): PageQueryBuilder<QB>;
}
interface LimitMethod<QB extends AnyQueryBuilder> {
(limit: number): PageQueryBuilder<QB>;
}

I think, both of these methods should just be returning QB instead of PageQueryBuilder<QB>.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions