Skip to content

Comments

Pin CI to non-broken rails main#1429

Merged
joelhawksley merged 3 commits intomainfrom
test-ci
Jul 21, 2022
Merged

Pin CI to non-broken rails main#1429
joelhawksley merged 3 commits intomainfrom
test-ci

Conversation

@joelhawksley
Copy link
Member

rails/rails#45614 broke our Global Output Buffer, which we should just remove at this point. Pinning for now while we resolve other issues.

rails/rails#45614 broke
our Global Output Buffer
@joelhawksley joelhawksley requested a review from a team as a code owner July 21, 2022 16:00
Copy link
Contributor

@BlakeWilliams BlakeWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Should we open an issue to address this so we don't stick to that ref for too long?

@joelhawksley joelhawksley merged commit f4fdae7 into main Jul 21, 2022
@joelhawksley joelhawksley deleted the test-ci branch July 21, 2022 16:16
claudiob pushed a commit to claudiob/view_component that referenced this pull request Dec 22, 2023
* Pin CI to non-broken rails main

rails/rails#45614 broke
our Global Output Buffer

* I don't know why standard failed here but 🤷

* add changelog
claudiob pushed a commit to claudiob/view_component that referenced this pull request Jan 3, 2024
* Pin CI to non-broken rails main

rails/rails#45614 broke
our Global Output Buffer

* I don't know why standard failed here but 🤷

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants