Add "Exclude MQTT" filter to the Nodes list#1
Merged
VictorioBerra merged 3 commits intomainfrom Mar 17, 2026
Merged
Conversation
Co-authored-by: VictorioBerra <[email protected]>
Copilot
AI
changed the title
[WIP] Add exclude MQTT filter to Nodes view
Add "Exclude MQTT" filter to the Nodes list
Mar 17, 2026
feature/node/src/commonMain/kotlin/org/meshtastic/feature/node/list/NodeListViewModel.kt
Outdated
Show resolved
Hide resolved
…haining Co-authored-by: VictorioBerra <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes relayed via MQTT are already tracked in
Node.viaMqttand surfaced in the UI ("via MQTT" label), but there was no way to filter them out of the node list. This adds an "Exclude MQTT" toggle alongside the existing node filters.Changes
Filter infrastructure
UiPreferencesDataSource—exclude-mqttDataStore key,excludeMqttStateFlow,setExcludeMqtt()NodeFilterPreferences— exposesexcludeMqttflow, addstoggleExcludeMqtt()NodeFilterState— newexcludeMqtt: Boolean = falsefieldViewModel wiring
excludeMqttis fed directly as a third input into thenodeFiltercombine rather than going throughNodeFilterToggles. This keepsfilterTogglesas the original clean 5-flow combine (the typed-lambdacombineoverload caps at 5 flows) and avoids chaining:Filter logic
GetFilteredNodesUseCaseadds a post-processing step:.filter { if (filter.excludeMqtt) !node.viaMqtt else true }UI
NodeFilterTextField— newexcludeMqtt/onToggleExcludeMqttparams; checkbox added to the filter dropdownNodeListScreen(Android) andDesktopAdaptiveNodeListScreenpass the new params through✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.