Skip to content

k8s-stack: added per-group additionalGroupByLabels#2931

Merged
AndrewChubatiuk merged 2 commits into
masterfrom
per-group-additionalGroupByLabels
May 27, 2026
Merged

k8s-stack: added per-group additionalGroupByLabels#2931
AndrewChubatiuk merged 2 commits into
masterfrom
per-group-additionalGroupByLabels

Conversation

@AndrewChubatiuk

@AndrewChubatiuk AndrewChubatiuk commented May 26, 2026

Copy link
Copy Markdown
Collaborator

added additionalGroupByLabels variable that overrides defaultRules.additionalGroupByLabels
fixes #2832


Summary by cubic

Add per-group additionalGroupByLabels for k8s-stack rule groups. You can now set group_by labels per group, replacing the global defaults for that group.

  • New Features

    • Add defaultRules.groups.<group>.additionalGroupByLabels to replace defaultRules.additionalGroupByLabels for that group.
    • Templates/codegen use the per-group list when set, always append the cluster label, and dedupe labels.
    • Regenerated rule files to use the new behavior; minor dashboard cleanup and values.yaml docs.
  • Migration

    • No changes required. To use, set defaultRules.groups.<group>.additionalGroupByLabels for the groups you want to override.

Written for commit 6b2e2d7. Summary will update on new commits. Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 46 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread hack/rules-and-dashboards/main.go Outdated
Comment thread charts/victoria-metrics-k8s-stack/CHANGELOG.md Outdated
@AndrewChubatiuk AndrewChubatiuk force-pushed the per-group-additionalGroupByLabels branch from 1c25a20 to bfaafbf Compare May 26, 2026 17:40
@AndrewChubatiuk AndrewChubatiuk force-pushed the per-group-additionalGroupByLabels branch from bfaafbf to f68c82c Compare May 26, 2026 17:41
Comment thread charts/victoria-metrics-k8s-stack/CHANGELOG.md Outdated
Co-authored-by: Vadim Rutkovsky <[email protected]>
Signed-off-by: Andrii Chubatiuk <[email protected]>
@AndrewChubatiuk AndrewChubatiuk merged commit a0ad756 into master May 27, 2026
9 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the per-group-additionalGroupByLabels branch May 27, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hack k8s-stack k8s-stack helm chart related issue metrics

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: extra group by variable for victoriametrics cluster

2 participants