k8s-stack: ignore operator webhook validation#2875
Merged
Conversation
onedr0p
requested review from
AndrewChubatiuk,
vrutkovs and
zekker6
as code owners
Contributor
Author
|
I'm going to change back the default to Fail in the operator and override the default to IgnoreOnInstallOnly in the stack chart. |
…webhook validation Signed-off-by: Devin Buhl <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="charts/victoria-metrics-operator/templates/webhook.yaml">
<violation number="1" location="charts/victoria-metrics-operator/templates/webhook.yaml:47">
P1: `IgnoreOnInstallOnly` relies on `Release.IsInstall`, which stays install-like in render-only/GitOps workflows, so the webhook can remain `Ignore` permanently instead of switching to `Fail` after the first install.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
onedr0p
changed the title
Signed-off-by: Devin Buhl <[email protected]>
onedr0p
changed the title
AndrewChubatiuk
approved these changes
May 3, 2026
Collaborator
|
LGTM! Thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2874
Summary by cubic
Adds
IgnoreOnInstallOnlysupport foradmissionWebhooks.policy. Invictoria-metrics-k8s-stack, default the operator webhook policy toIgnoreso the stack installs and upgrades in one pass; the operator chart still defaults toFail.policyisIgnoreOnInstallOnly, setfailurePolicytoIgnoreon install andFailon upgrade; otherwise honor explicitFail/Ignore, defaulting toFail.victoria-metrics-k8s-stacksetspolicy: Ignoreby default and documents override toFailfor strict validation.Written for commit 9d125cb. Summary will update on new commits.