Skip to content

+ hdpi fixes#74

Merged
CyberShadow merged 20 commits intoVerySleepy:masterfrom
djdron:hdpi
Jul 23, 2020
Merged

+ hdpi fixes#74
CyberShadow merged 20 commits intoVerySleepy:masterfrom
djdron:hdpi

Conversation

@djdron
Copy link
Copy Markdown
Contributor

@djdron djdron commented Jul 17, 2020

note : you need to upgrade wxwidgets to latest master to use HDPI features

@CyberShadow
Copy link
Copy Markdown
Member

Hi and thank you for your contribution.

Unfortunately, as I don't use Windows (or Very Sleepy), I can only accept a contribution if it is complete and passes the CI. So, I need to ask you that any changes required to upgrade wxWidgets are added to this pull request before it can be merged.

Could you also please update the commit messages (here and in the other PRs) to be consistent with the format already used in this project?

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 18, 2020

Seems build is OK now, but tests failed ?

@CyberShadow
Copy link
Copy Markdown
Member

"Build execution time has reached the maximum allowed time for your plan (60 minutes)."

It looks like it got stuck on execution. Possibly it is showing a pop-up or error message.

Perhaps the cause can be determined by connecting via RDP:
https://www.appveyor.com/docs/how-to/rdp-to-build-worker/

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 18, 2020

I need to setup appveyor to my fork ?

@CyberShadow
Copy link
Copy Markdown
Member

I'm not 100% sure if it will work, but you could try to temporarily edit appveyor.yml in this pull request.

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 19, 2020

image
It got stuck on this in some tests. I killed Sleepy process and tests continue.

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 20, 2020

reproduced this on local machine, trying to fix

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 20, 2020

Seems to work ok now)
What did you mean to do with commit messages? remove "+" sign ?

@CyberShadow
Copy link
Copy Markdown
Member

CyberShadow commented Jul 21, 2020

Thank you very much! This is fantastic work.

What did you mean to do with commit messages? remove "+" sign ?

Up to you if you want to do this and otherwise clean up history; alternatively I can squash everything into a single commit.

If you want to clean up history, what I would do is:

  • Commit messages:

    • Remove the + sign as you mentioned (does it mean something? It's not a convention I've seen anywhere else)
    • If the change pertains to a single file or component, put its name at the front (e.g. "mythread: Commit message here")
    • Uppercase the first letter
    • Reword the subject so that it follows the rule that "If applied, this commit will your subject line here"

    See e.g. https://chris.beams.io/posts/git-commit/ for details.

  • Commit order:

    • Remove commits that have been reverted
    • Squash together commits that, together, form a single logical and self-contained change
    • Reorder commits so that ideally the test suite continues passing after every commit (meaning, early commits may introduce changes that are only used/activated by later commits)

Up to you if this is something that you want to do.

@djdron
Copy link
Copy Markdown
Contributor Author

djdron commented Jul 23, 2020

Thank you very much! This is fantastic work.

You're welcome) Thanks for this beautiful profiler.

Up to you if you want to do this and otherwise clean up history; alternatively I can squash everything into a single commit.

Please do it, because i don't know how to re-arrange & combine pushed commits.
Do i need to create new branch from master, cherry-pick them, combine if necessary and create new PR ?
Or i need to push --force ?

See e.g. https://chris.beams.io/posts/git-commit/ for details.

Thanks for info.

Up to you if this is something that you want to do.

I don't really want

@CyberShadow CyberShadow merged commit 9162f34 into VerySleepy:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants