Jump to the correct source line as shown in list views#58
Merged
CyberShadow merged 1 commit intoVerySleepy:masterfrom Jul 11, 2018
Merged
Conversation
- Applies to 'Called From' and 'Call Stacks' view where the line numbers are not the procedure entry points - Makes multiple entries of the same function in the 'Called From' jump to the correct source line - Keep the correct line number reference in the Back/Forward history - This also fixes viewing 64bit process profile .sleepy files in the 32bit version (avoid 64bit ptr to long cast)
CyberShadow
approved these changes
Jul 11, 2018
Member
CyberShadow
left a comment
CyberShadow
left a comment
There was a problem hiding this comment.
Thank you for these improvements. Unfortunately my Windows VM is currently inaccessible, but the source changes look good, and the CI is passing (for some reason it's not showing up here though), so I'll go ahead and merge these.
This was referenced Aug 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly for convenience because I find it unintuitive to (single) click through the entries in the 'Called From' list and have it jump not to the line of the actual call. Fixing that also lead to fixing crashes when loading a 64bit process profile .sleepy file in the 32bit version.