Unload symbols (PDB files) after profiling by attaching#57
Merged
CyberShadow merged 1 commit intoVerySleepy:masterfrom Jul 11, 2018
Merged
Conversation
CyberShadow
approved these changes
Jul 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When profiling not by loading a .sleepy file but by attaching to the process from the ThreadPicker the attach_info member gets allocated with
new AttachInfoand never gets deleted even after the ThreadPicker gets deleted.This causes the symbols (PDB files) to be locked forever until Very Sleepy is closed. This makes it annoying to test code changes while keeping multiple profile runs open because a program can't be recompiled while its PDB file is locked.