Added command-line option '/amt' and '/ambt' to profile an existing process's certain thread by setting its process id#47
Closed
RammerChoi wants to merge 2 commits intoVerySleepy:masterfrom
Closed
Conversation
…rocess's certain thread by setting its process id
Member
|
Could you please split out the refactoring in the second commit into a commit of its own? |
CyberShadow
reviewed
Jul 27, 2017
| catch (const std::exception&) | ||
| { | ||
| throw SleepyException("Not valid process id: " + processId); | ||
| } |
Member
There was a problem hiding this comment.
Please refactor the common code in AttachToProcess, AttachToMostBusyThread, and AttachToMostBusyThread to avoid repetition.
Perhaps an attachMode enum parameter?
| { wxCMD_LINE_OPTION, "r", "", "Runs an executable and profiles it.", wxCMD_LINE_VAL_STRING, wxCMD_LINE_PARAM_OPTIONAL|wxCMD_LINE_NEEDS_SEPARATOR }, | ||
| { wxCMD_LINE_OPTION, "a", "", "Attaches to a process (by its PID) and profiles it.", wxCMD_LINE_VAL_STRING, wxCMD_LINE_PARAM_OPTIONAL|wxCMD_LINE_NEEDS_SEPARATOR }, | ||
| { wxCMD_LINE_OPTION, "amt", "", "Attaches to a process's main thread (by its PID) and profiles it.", wxCMD_LINE_VAL_STRING, wxCMD_LINE_PARAM_OPTIONAL | wxCMD_LINE_NEEDS_SEPARATOR }, | ||
| { wxCMD_LINE_OPTION, "ambt", "", "Attaches to a process's most busy thread (by its PID) and profiles it.", wxCMD_LINE_VAL_STRING, wxCMD_LINE_PARAM_OPTIONAL | wxCMD_LINE_NEEDS_SEPARATOR }, |
Member
There was a problem hiding this comment.
I think it would make more sense to have a separate parameter to indicate which threads to attach (i.e. /a /mt instead of /amt).
Contributor
Author
|
Thank you for your advice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'/amt' is an option to profile "main thread".
And '/ambt' is an option to profile "most busy thread".
These were added because I needed.
But it may helpful to someone else, so I open a pull request.
please consider this request.