Skip to content

Autocomplete in the filters view, rearrangable tabs, and a few bugfixes#3

Closed
benjymous wants to merge 5 commits intoVerySleepy:masterfrom
benjymous:my
Closed

Autocomplete in the filters view, rearrangable tabs, and a few bugfixes#3
benjymous wants to merge 5 commits intoVerySleepy:masterfrom
benjymous:my

Conversation

@benjymous
Copy link
Copy Markdown

  • Enabled some properties on wxAuiNotebook that lets you drag-order the tabs, and snap them out into side-by-side panes, which is pretty neat! Sadly doesn't give you full VS style adjustment, and doesn't offer functionality to save your customised layout
  • The text fields in the Filters view now autocomplete based on the data from the database, for quicker searching
  • A couple of bugfixes related to selecting items in views when filters are enabled
  • Tidied the filters panel layout slightly

@CyberShadow
Copy link
Copy Markdown
Member

Hi there,

I just pushed some commits of my own. I'm afraid our work has diverged a bit. I'll try to cherry-pick the relevant commits.

Could you please check if the bugfix commits are still needed for my master? I've reworked that area of code in a way that I think clamps down on that category of bugs.

@CyberShadow
Copy link
Copy Markdown
Member

Oops, just realized I committed some debug changes! I'll clean it up in a bit.

@CyberShadow
Copy link
Copy Markdown
Member

OK, fixed and force-pushed!

By the way, I've emailed Richard Mitton two days ago, but no reply so far. I guess I'll ping him on Twitter later today.

@benjymous
Copy link
Copy Markdown
Author

Yeah, those fixes were down to how it handled remapping list indices when filtered - now that it's pre-filtering the results, it shouldn't be an issue.

He seems fairly active on Twitter, so hopefully you might get a response there!

@CyberShadow
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants