Skip to content

Filters and Highlights#2

Merged
CyberShadow merged 5 commits intoVerySleepy:masterfrom
benjymous:my
Aug 13, 2013
Merged

Filters and Highlights#2
CyberShadow merged 5 commits intoVerySleepy:masterfrom
benjymous:my

Conversation

@benjymous
Copy link
Copy Markdown

I've pushed a few extra things I've added whilst using sleepy to track down performance bottlenecks

This adds:

  • A filters pane - lets you quickly filter the displayed trace entries to a particular function name, module or sourcefile (including substrings, so you can, for example just show MyClass:: or code in C:\mycode\myapp) - right click entries to quickly set filters, or enter them manually in the Filters tab
  • Right click an entry to highlight it - makes it much easier to find the function you're looking at when changing filtering / sorting / etc
  • Displays the filename of the dump in the titlebar, so if you're comparing multiple dumps, you can easily see which is which

benjymous added 5 commits June 14, 2013 15:35
…unction name, module, or source file (or bits of each) through (case sensitive) substring searches
Conflicts:
	src/wxProfilerGUI/mainwin.cpp
	src/wxProfilerGUI/profilergui.cpp
@CyberShadow
Copy link
Copy Markdown
Member

Hi, nice to hear from you again. I'll merge and check it out now.

Any idea why the VS2010 project file uses Unix line endings on your end and Windows line endings on mine? VS2012 insisted on converting them after I saved the file. There'll be a merge conflict, but I'll take care of it.

I'll ping Richard Mitton and ask him what's the status with accepting patches (he never published the ones I sent him last year). Maybe he'd be OK with letting someone else run the project on GitHub. I've noticed a few more forks like this one pop up on GitHub and Bitbucket, which is disappointing since good work goes wasted and unnoticed. Would be nice to centralize development again.

CyberShadow added a commit that referenced this pull request Aug 13, 2013
Filters and Highlights
@CyberShadow CyberShadow merged commit c75c69f into VerySleepy:master Aug 13, 2013
@CyberShadow
Copy link
Copy Markdown
Member

Merged and pushed. I hope you don't mind, I've taken the liberty to move the Filters tab to the end of the tab list, since it's likely not the tab that people are most interested in seeing at first in most cases.

@benjymous
Copy link
Copy Markdown
Author

Yeah, that seems fine to me. It might make more sense in the bottom pane, now that you've added tabs there too - the filters UI was basically just the bare minimum to get something working (as I didn't want to spend all day figuring out how to do more advanced stuff in Wx!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants