Skip to content

Added option to limit how long the profiler runs for, build fixes for VS2010, added gitignore#1

Merged
CyberShadow merged 7 commits intoVerySleepy:myfrom
benjymous:my
Jun 16, 2013
Merged

Added option to limit how long the profiler runs for, build fixes for VS2010, added gitignore#1
CyberShadow merged 7 commits intoVerySleepy:myfrom
benjymous:my

Conversation

@benjymous
Copy link
Copy Markdown

This adds a checkbox and textbox on the launch gui that lets you limit how many seconds the profiler will gather data for. Not overly accurate, but better than my reflexes at hitting stop!

Also added a .gitignore file and build configs for VS2010

@CyberShadow
Copy link
Copy Markdown
Member

Hi, thanks. Just to make it clear, you're aware that this is just my fork of Very Sleepy, and not the official version?

@benjymous
Copy link
Copy Markdown
Author

Yeah, just figured it made sense to keep everything together, rather than having another separate fork!

I'm also working on adding a filters panel that makes searching the data much easier (substring search on procname, module or sourcefile, and combinations of the above)

CyberShadow added a commit that referenced this pull request Jun 16, 2013
Added option to limit how long the profiler runs for, build fixes for VS2010, added gitignore
@CyberShadow CyberShadow merged commit e9a2d3b into VerySleepy:my Jun 16, 2013
@CyberShadow
Copy link
Copy Markdown
Member

OK, thanks!

I should probably rename the master branch to upstream, and my to master.

@CyberShadow
Copy link
Copy Markdown
Member

Hi,

Just FYI, I went through the code again these days and noticed that the option you implemented was already there, but only accessible as a command-line option. I've now merged the two implementations in 7a6249f.

I'm not really sure what's the purpose of the patch in profilerthread.cpp, since it seems to be duplicating the functionality of capturewin.cpp. I've removed it as well, but maybe it has a reason for being there?

@benjymous
Copy link
Copy Markdown
Author

Ahh, I entirely missed that stuff - removing the code duplication totally makes sense.

One thing you seem to have also removed is the progressMax stuff, which made the progress bar operate like a real progress bar when the sample time was fixed (rather than the default weird logarithmic progress you get by default)

@CyberShadow
Copy link
Copy Markdown
Member

That's still in there, I just changed the math a bit to make the progressMax variable unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants