Add support for scrubbing nullable numeric IDs#352
Merged
Conversation
khellang
reviewed
May 10, 2021
| @@ -167,7 +167,11 @@ protected override JsonProperty CreateProperty(MemberInfo member, MemberSerializ | |||
| propertyType == typeof(int) || | |||
There was a problem hiding this comment.
Would it be easier to just do propertyType = Nullable.GetUnderlyingType(propertyType) ?? propertyType; first?
Member
There was a problem hiding this comment.
good point. i will make this change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#351 Added support for scrubbing numeric IDs (Thanks @SimonCropp! 😄). Just ran into a case where the IDs may be nullable, and as this will be a common scenario for ForeignKey situations, I updated the implementation to support nullable versions.
Tweaked tests to check a nullable ID with and without value.