[QT] Proposed fix for (one type of) force_return errors#996
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Apr 21, 2022
Merged
Conversation
codeofalltrades
added
Issue Type: Bug
WetOne
approved these changes
Apr 17, 2022
Collaborator
|
utACK 1c07fe1 |
Zannick
approved these changes
Apr 21, 2022
codeofalltrades
removed
the
Tag: Waiting For Code Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When dealing with some orphan transactions, some addresses aren't in the address map, and so when we look them up we get an invalid return value to indicate we didn't find it.
Fix
Verify the address is valid before trying to get the boost value.
Tested
Windows 10 testnet wallet.