[RPC] Correct getblockstats fee calculation#990
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Feb 19, 2022
Merged
[RPC] Correct getblockstats fee calculation#990codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
Otherwise fall back to subtraction (mainly basecoin-to-basecoin) or skipping.
Zannick
added
Component: RPC
Collaborator
|
utACK 95c4740 |
WetOne
approved these changes
Feb 18, 2022
codeofalltrades
removed
the
Tag: Waiting For Code Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current implementation always performs a subtraction
ins - outsto calculate fee, which is only correct for basecoin-to-basecoin, and results in zerocoin spends appearing as the fee. CT/RingCT and Zerocoin Minting/Spending include a ct_fee output that we can use (ZC spends have a ct_fee of 0 but at least that lets us skip the subtraction).