Skip to content

C++17 and macOS Catalina#984

Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
eugene-so:c++17
Feb 19, 2022
Merged

C++17 and macOS Catalina#984
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
eugene-so:c++17

Conversation

@eugene-so
Copy link

@eugene-so eugene-so commented Jan 16, 2022

Note
This entire branch was already reviewed and approved on Nov 2021. We just need to decide on bringing it to the master branch.

Problem

Support compiling on OSX catalina (macOS build server 10.15) using C++17
Upgrade to boost 1.70


Solution

Ported changes from bitcoin repo related to the build tools described above

Bounty PR
#ZZZ
Bounty Payment Address
sv1qqp6aptgvgp9t9h8sgzkqmu6cgq2e20l9x6fsl5ask7t3ygy2jagftcpq0x5z0h522ca5h06qq3hx33pke00r7gjt3j24n896gf55y68ptrmjqqqqd8lz3

Unit Testing Results

Successful build on macOS 10.15+ and perform regression tests

@seanPhill
Copy link
Collaborator

seanPhill commented Jan 16, 2022 •
edited
Loading

(Running this downloaded from Github Actions today.)
I'm getting (on my Catalina iMac) this message (repeated 20 times) when I launch veil-qt from Terminal, that was not happening on the current master, but I can't find any reference to it, and it has made no apparent change to the running wallet. I'm eager to commit this, presumably squashing the 164 commits!

2022-01-16 15:42:35.883 veil-qt[2423:81004] CoreText note: Client requested name ".SFNSMono-Regular", it will get Times-Roman rather than the intended font. All system UI font access should be through proper APIs such as CTFontCreateUIFontForLanguage() or +[NSFont systemFontOfSize:].

This font message is not happening on my macOS Monterey (12.01) Mac.
Also not happening on my second macOS Catalina Mac! So, I wouldn't want this to hold it up.
Correction, it is happening, but only twice. Not a drama. --> Final correction: 20 times, just like the other one, but it's working fine.

Commit squashed?

Upgrade build server to compile using C++17, mac os 10.15 and boost 1…
3b3e985 
….70.

Supports compilation on osx catalina.
@eugene-so
Copy link
Author

eugene-so commented Jan 17, 2022

Squashed the commits.

@seanPhill seanPhill added the QA: Passed This has passed QA testing and can be merged to master label Jan 17, 2022
@codeofalltrades codeofalltrades merged commit f23bf74 into Veil-Project:master Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

QA: Passed This has passed QA testing and can be merged to master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eugene-so @seanPhill @codeofalltrades