[GUI|MINE] update for override of max thread usage#975
[GUI|MINE] update for override of max thread usage#975codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
Zannick
added
Component: GUI
CaveSpectre11
left a comment
CaveSpectre11
left a comment
There was a problem hiding this comment.
Also:
<string>Use your compter resources to create hashes looking for block solutions.</string>
has both a spelling error (compter) and an extra space between "hashes" and "looking"
Also; clicking "use max threads" gave me the 2^31 threads and filled in 'number of threads' with that number. I can enter a lower value into number of threads, but there's no way to get it to take, so I would have to click the - a couple billion times to get it to reduce.
WetOne
force-pushed
the
MiningOverride
branch
2 times, most recently
from
100203c to
b133500
Compare
CaveSpectre11
added
Tag: Waiting For Code Review
CaveSpectre11
left a comment
CaveSpectre11
left a comment
There was a problem hiding this comment.
- Still seeing spelling error (compter) and extra spaces between 'hashes looking' at the top of the page
- Still seeing RandomX set 4 threads and with 4 CPU and 'exceeding recommended number of threads'
- Since we can't edit the number of threads only up/down I think "use Max threads" should be disabled when it's setting it to INT_MAX
|
I'm addressing the first two. I'm not quick clear on what you are asking for the last one. Are you saying that when the value is already at max that the "Use Max Threads" button should be disabled? |
WetOne
force-pushed
the
MiningOverride
branch
from
b133500 to
2e90ef7
Compare
|
Updated per comments. |
WetOne
force-pushed
the
MiningOverride
branch
from
2e90ef7 to
41888ea
Compare
|
utACK 41888ea |
codeofalltrades
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
4 participants
Problem
Original implementation of the Mining Tab limits the user to only a number of threads equivalent to the number of cores the computer has. This is OK for SHA256 but should be allowed to be override for other algorithms.
Root Cause
No option for override
Solution
Implement the ability to override.