[Consensus][RingCT] Correctly track and test RingCT spends.#972
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Mar 13, 2022
Merged
[Consensus][RingCT] Correctly track and test RingCT spends.#972codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
WetOne
approved these changes
Oct 21, 2021
Collaborator
|
utACK e8c32ca |
1. When creating a transaction, the record has dummy inputs, but we
want to mark the actual txo's as pending spend so later transactions
don't attempt to spend them.
2. When verifying that we aren't double-spending, if we're only testing
that a transaction can be accepted, don't track the inputs as though
we're trying to commit the transaction. This way we can test
accepting a transaction and later commit it (e.g. as part of a batch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Creating multiple ringct spend transactions in a batch (as part of #970) does not work because of these two similar issues.
Solution
Tested
On regtest with other changes for #970.