[GUI][Zerocoin] transaction list - handle receive from zerocoin transactions#946
Conversation
codeofalltrades
added
Component: GUI
| bool fBech32 = false; | ||
| if (boost::get<CScriptID>(&wtx.txout_address[i])){ | ||
| fBech32 = true; | ||
| } |
There was a problem hiding this comment.
NIT: Can this be condensed into a single line instead of the if? say, something like
bool fBech32 = (bool)boost::get<CScriptID>(...); or boost::get<CScriptID>(...) != ... ?
There was a problem hiding this comment.
That's true:
bool fBech32 = boost::get<CScriptID>(&wtx.txout_address[i]) would do the trick; but functionally it's the same and and it's not against style; so I'll say that's a NIT
Another NIT: space between the end of the if and the {
But given problems with this problem, I'm not concerned with holding it up.
| bool fBech32 = false; | ||
| if (boost::get<CScriptID>(&wtx.txout_address[i])){ | ||
| fBech32 = true; | ||
| } |
There was a problem hiding this comment.
That's true:
bool fBech32 = boost::get<CScriptID>(&wtx.txout_address[i]) would do the trick; but functionally it's the same and and it's not against style; so I'll say that's a NIT
Another NIT: space between the end of the if and the {
But given problems with this problem, I'm not concerned with holding it up.
|
utACK 352d78e |
CaveSpectre11
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
4 participants
Problem
The wallet transaction list was updated to show the correct address #898
Zerocoins sent to a bv1 address were causing the force_return error. The address format is bech32 however the decode method was trying to decode the address as bech32 = false.
Root Cause
The address format is bech32 however the decode method was trying to decode the address as bech32 = false.
Solution
Decode the address using the correct format.
Unit Testing Results