Skip to content

[RPC][Trivial] Tweak exportzerocoins example to be sensible#939

Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
CaveSpectre11:zcoinhelp
May 3, 2021
Merged

[RPC][Trivial] Tweak exportzerocoins example to be sensible#939
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
CaveSpectre11:zcoinhelp

Conversation

@CaveSpectre11
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 commented May 2, 2021

Problem

exportzerocoins help gives an example with a denomination of 5; which doesn't make any sense.

Examples:
> veil-cli exportzerocoins false 5
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "exportzerocoins", "params": [false 5] }' -H 'content-type: text/plain;' http://127.0.0.1:58812/

Solution

Tweak it to show an example of 10

Examples:
> veil-cli exportzerocoins false 10
> curl --user myusername --data-binary '{"jsonrpc": "1.0", "id":"curltest", "method": "exportzerocoins", "params": [false 10] }' -H 'content-type: text/plain;' http://127.0.0.1:58812/

@CaveSpectre11 CaveSpectre11 added Coin Type: Zerocoin Specifically related to zerocoin Component: RPC Related to the console commands themselves. Tag: Waiting For Code Review Waiting for code review from a core developer labels May 2, 2021
@CaveSpectre11 CaveSpectre11 self-assigned this May 2, 2021
codeofalltrades
codeofalltrades approved these changes May 3, 2021
View reviewed changes
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 3cf9ddf

@codeofalltrades codeofalltrades merged commit f5e7670 into Veil-Project:master May 3, 2021
@CaveSpectre11 CaveSpectre11 added Code Review: Passed Dev Status: Merged Issue is completely finished. and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeofalltrades codeofalltrades codeofalltrades approved these changes

@Zannick Zannick Awaiting requested review from Zannick

@WetOne WetOne Awaiting requested review from WetOne

Assignees

@CaveSpectre11 CaveSpectre11

Labels

Code Review: Passed Coin Type: Zerocoin Specifically related to zerocoin Component: RPC Related to the console commands themselves. Dev Status: Merged Issue is completely finished.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@CaveSpectre11 @codeofalltrades