[Core] Properly shut down veild if init fails.#935
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Apr 26, 2021
Merged
[Core] Properly shut down veild if init fails.#935codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
Fixes Veil-Project#934: Background threads were hanging after being interrupted, because they were looking to `ShutdownRequested()`, which was only being set by `StartShutdown()` on SIGTERM. Solution is to call `StartShutdown()` when veild fails init and goes to interrupt running threads.
codeofalltrades
approved these changes
Apr 24, 2021
Collaborator
codeofalltrades
left a comment
codeofalltrades
left a comment
There was a problem hiding this comment.
ACK a66022a
Tested on Win 10
codeofalltrades
added
Component: Core App
CaveSpectre11
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
veild doesn't shut down properly if it fails during init.
Root Cause
Background threads were hanging after being interrupted, because they were looking to
ShutdownRequested(), which was only being set byStartShutdown()on SIGTERM.Solution
Solution is to call
StartShutdown()when veild fails init and goes to interrupt running threads.PR
#934
Testing
Set
autospend=1andautospendaddress=<basecoin address>(or make a similar error that should cause it to close with an error on startup) in your veil.conf and run veild with-printtoconsole.