[Logging] Define a STAKING log category.#928
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Apr 19, 2021
Merged
[Logging] Define a STAKING log category.#928codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
codeofalltrades
added
Component: Miner
CaveSpectre11
approved these changes
Apr 18, 2021
Collaborator
CaveSpectre11
left a comment
CaveSpectre11
left a comment
There was a problem hiding this comment.
utACK 140333a
with one minor nit
This allows separation of log messages related to staking from log messages about block creation, which currently includes all generic block creation messages as well as DarkGravityWave difficulty measurements.
codeofalltrades
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BLOCKCREATIONis a very noisy log category. It includes DarkGravityWave logs (which are noisy), staking messages, and generic block creation logs.Root Cause
Not enough log categories.
Solution
Added a new log category specific to staking. Staking-relevant messages that were previously
BLOCKCREATIONhave been moved over.Bounty PR
None
Bounty Payment Address
sv1qqpswvjy7s9yrpcmrt3fu0kd8rutrdlq675ntyjxjzn09f965z9dutqpqgg85esvg8mhmyka5kq5vae0qnuw4428vs9d2gu4nz643jv5a72wkqqq73mnxrUnit Testing Results
Tested on win10 x64 WLS Ubuntu 20.04: built and ran unittests individually, comparing results to a previous master commit.