[Staking][GUI] Unlock wallet for staking dialogue on click#924
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Apr 26, 2021
Merged
Conversation
Rock-N-Troll
changed the title
CaveSpectre11
added
Component: GUI
Collaborator
|
ack b8294ee |
Collaborator
|
What is supposed to do? I clicked placed, the wallet seems for function the same. |
Author
|
Clicking the toggle bottom left of screen will also open the unlock wallet password dialog as shown in the screenshot where as previously it would only show the notification that you should unlock wallet for staking |
CaveSpectre11
added
Code Review: Passed
and removed
Tag: Waiting For Code Review
| UnlockPasswordDialog *dialog = new UnlockPasswordDialog(/*fUnlockForStakingOnly*/true, this->walletModel, mainWindow); | ||
| if(openDialogWithOpaqueBackground(dialog, mainWindow, 4)){ | ||
| openToastDialog("Wallet unlocked for staking", mainWindow); | ||
| }else{ |
Collaborator
There was a problem hiding this comment.
NIT: Follow consistent spacing to rest of the module (space between code and brackets
if () {
} else {
etc...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to pull request: #913 (and mentioned there as well. This is the separated pull request)
#913 (comment)