[Logging][Mining] Add BCLog::MINING category.#920
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Apr 10, 2021
Merged
[Logging][Mining] Add BCLog::MINING category.#920codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
CaveSpectre11
requested changes
Apr 5, 2021
Collaborator
CaveSpectre11
left a comment
CaveSpectre11
left a comment
There was a problem hiding this comment.
One small correction and then it should be good.
CaveSpectre11
added
Component: Core App
Adds a new logging category MINING to aid debugging mining specifically without including block template creation logs that may be noisier. Converts most logs in BitcoinMiner and RandomXMiner to use this category instead of BLOCKCREATION. Fixes one unlikely logging statement to include the function name.
codeofalltrades
approved these changes
Apr 7, 2021
Collaborator
codeofalltrades
left a comment
codeofalltrades
left a comment
There was a problem hiding this comment.
ACK 8dfd59a
Tested on Win10
codeofalltrades
added
Code Review: Passed
Tag: Waiting For QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Mining code uses the
BLOCKCREATIONlogging category, which includes logging about difficulty targets, staking, zerocoins, etc, making it harder to investigate mining-specific issues.Root Cause
Using the
BLOCKCREATIONcategory for lots of different information.Solution
Adds a new logging category
MININGto aid debugging mining specificallywithout including block template creation logs that may be noisier.
Converts most logs in BitcoinMiner and RandomXMiner to use this category
instead of
BLOCKCREATION.Fixes one unlikely logging statement to include the function name.
Bounty Payment Address
sv1qqpswvjy7s9yrpcmrt3fu0kd8rutrdlq675ntyjxjzn09f965z9dutqpqgg85esvg8mhmyka5kq5vae0qnuw4428vs9d2gu4nz643jv5a72wkqqq73mnxrUnit Testing Results
Tested by running and sending the command
logging [\"mining\"]to enable.