Skip to content

[GUI] Capitalize First Letter in Menu Option Words#917

Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Rock-N-Troll:capitalize_menu_items
Apr 10, 2021
Merged

[GUI] Capitalize First Letter in Menu Option Words#917
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Rock-N-Troll:capitalize_menu_items

Conversation

@Rock-N-Troll
Copy link

@Rock-N-Troll Rock-N-Troll commented Apr 2, 2021

(Recreated branch due to commit issue)

Existing:
image

New:
image

@CaveSpectre11
Copy link
Collaborator

Please squash your commits

Capitalize in translations. addresses Unlock Wallet For Staking
additional changes to make unlock for staking capitalized
@Rock-N-Troll Rock-N-Troll force-pushed the capitalize_menu_items branch from 38591a1 to d9720e3 Compare April 3, 2021 23:56
@Rock-N-Troll
Copy link
Author

somehow I manage to always get coat's last commit involved, but hopefully shouldn't be an issue here

@CaveSpectre11 CaveSpectre11 added Component: GUI Primarily related to the display of the user interface Tag: Waiting For Code Review Waiting for code review from a core developer labels Apr 4, 2021
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what happened here:

image

widget = ui->btnBalance;
posy = 0;
posx = widget->pos().rx()+150;
posx = widget->pos().rx()+190;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure this is covered in your description of what was done.

Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d9720e3
Tested in Win10

@codeofalltrades codeofalltrades merged commit ddd0b15 into Veil-Project:master Apr 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Component: GUI Primarily related to the display of the user interface Tag: Waiting For Code Review Waiting for code review from a core developer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants