Skip to content

[RPC] Return mining addresses in listaddresses rpc command#911

Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Rock-N-Troll:listaddresses_include_mining
Apr 10, 2021
Merged

[RPC] Return mining addresses in listaddresses rpc command#911
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Rock-N-Troll:listaddresses_include_mining

Conversation

@Rock-N-Troll
Copy link

@Rock-N-Troll Rock-N-Troll commented Mar 28, 2021 •
edited by CaveSpectre11
Loading

listaddresses RPC command now handles mining addresses in the listaddresses command

image

Addresses issue: #863

@CaveSpectre11 CaveSpectre11 added Component: RPC Related to the console commands themselves. Tag: Waiting For Code Review Waiting for code review from a core developer labels Mar 28, 2021
CaveSpectre11
CaveSpectre11 reviewed Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Adjusted the PR text to be contained rather than just a link to the obsolete PR)

utACK 6a00e1a

CaveSpectre11
CaveSpectre11 approved these changes Mar 28, 2021
View reviewed changes
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Adjusted the PR text to be contained rather than just a link to the obsolete PR)

utACK 6a00e1a

@codeofalltrades
Copy link
Collaborator

codeofalltrades commented Apr 5, 2021

On this testnet wallet I'm not getting all the addresses with a balance.
getbalance 18849.99951080

listaddresses
[
  {
    "address": "n33B5MWFpq6S4scU95YNg99XALbSim6TL7",
    "amount": 0.00000000,
    "label": ""
  },
  {
    "address": "tv1qxrd7yuz309w2xpp34jv6676tf9zr047azcf4dj",
    "amount": 0.00000000,
    "label": ""
  },
  {
    "address": "tps1qqpryf8z35x2e9uw7sac8v2ljgj4gle8jvrnd6jnqslx9gd4f6lnd3qpq0fjsecfsxhe9z88034jy05aewrujev2fszezfr7n5rm42l8m60l5qqq4s5fjs",
    "amount": 0.00000000,
    "label": "stealth"
  },
  {
    "address": "tps1qqphrja9um9y0n6jcxhp4fnn8kjleqyetr8vf8glqrdh4887gtkkggspqv60lyg5hv4vucjtkjstnad05nj6e5szslf6n59vtgfeq2e2t3juqqqqj2s5z0",
    "amount": 0.00000000,
    "label": ""
  }
]

listaddressgroupings
[
  [
    [
      "mgNrjxfcbZv2gtS2CgBdQ8TnrhwS5SPfw2",
      250.00000000
    ]
  ],
  [
    [
      "moja7wbRUAYc9xkfStdzxZ46ENDu83Lve4",
      14000.00000000
    ]
  ],
  [
    [
      "mwSZXQbXzK26RxYBa1BBVWpuWDoVUMubHm",
      4550.00000000
    ],
    [
      "tv1qhl5e4cwrmpc78fyuqkf9gqtq69993g5dvp5nl3",
      49.99951080
    ]
  ]
]

@codeofalltrades codeofalltrades added Dev Status: In Progress Someone is actively working on this issue. and removed Tag: Waiting For Code Review Waiting for code review from a core developer labels Apr 5, 2021
@Rock-N-Troll
Copy link
Author

Rock-N-Troll commented Apr 5, 2021

In my testing, it seems to be related to address book only. Maybe that assumption needs to be changed

@Rock-N-Troll
Copy link
Author

Rock-N-Troll commented Apr 5, 2021

List Addresses command is designed to only display addresses in the wallet address book

help listaddresses
Lists addresses in the wallet Address Book.

help listaddressgroupings
Lists groups of addresses which have had their common ownership
made public by common use as inputs or as the resulting change
in past transactions

So it looks like the functionality is correct or at least adheres to the existing expectation

codeofalltrades
codeofalltrades approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 6a00e1a

@codeofalltrades codeofalltrades added Code Review: Passed Tag: Waiting For QA A pull review is waiting for QA to test the pull request and removed Dev Status: In Progress Someone is actively working on this issue. labels Apr 7, 2021
@codeofalltrades codeofalltrades merged commit 01b2ee5 into Veil-Project:master Apr 10, 2021
This was referenced May 21, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CaveSpectre11 CaveSpectre11 CaveSpectre11 approved these changes

@codeofalltrades codeofalltrades codeofalltrades approved these changes

Assignees

@Rock-N-Troll Rock-N-Troll

Labels

Code Review: Passed Component: RPC Related to the console commands themselves. Tag: Waiting For QA A pull review is waiting for QA to test the pull request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Rock-N-Troll @codeofalltrades @CaveSpectre11