[RPC][Mining] Extract last Hashspeed calculation#883
Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom Dec 14, 2020
Merged
[RPC][Mining] Extract last Hashspeed calculation#883codeofalltrades merged 1 commit intoVeil-Project:masterfrom
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
Conversation
Collaborator
Author
|
This addresses issue #875 |
Collaborator
|
Looks goods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users want to be able to see their current hashing speed
Solution
Extract the last calculated hashspeed and provide it in
getmininginfo. To note, this only pulls the last calculation that was done, and is not a real-time pull. It will be the average from the start of mining to the last calculation, from the time the firstgeneratecontinuous truewas run. In other words, this will take into account any 'breaks' taken in mining. e.g. if you have a script that turns off mining for a certain time; the hash speed calculations are still being run; and the break will be calculated into your overall hash rate.Logic was added to
setminingalgoto reset the statistical counters. So aftersetminingalgois issued, the statistics will restart on the nextgeneratecontinuous. This can be used to reset your counters even if you're not changing algorithms by setting your mining algo to the same algo:Note that for simplicity sake, the calculation is "hashes per second", so that it can remain a numerical value and users can wrap the use however they wish if they want to convert it to kh/s or mh/s [or whatever they desire]