[RPC] Remove lock check for listzerocoinamounts#870
Merged
CaveSpectre11 merged 1 commit intoVeil-Project:masterfrom Nov 15, 2020
Merged
[RPC] Remove lock check for listzerocoinamounts#870CaveSpectre11 merged 1 commit intoVeil-Project:masterfrom
CaveSpectre11 merged 1 commit intoVeil-Project:masterfrom
Conversation
CaveSpectre11
added
Coin Type: Zerocoin
CaveSpectre11
added
QA: Passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
listzerocoinamountsrequires a wallet to be unlocked to executeRoot Cause
There was a specific wallet unlocked check to prevent it's use without unlocking the wallet.
Solution
Remove the check so that the
listzerocoinamountsRPC command will execute against a locked walletNote
Generally there will be little to no change to the zerocoin implementation as we are currently in the process of phasing it out. However this was a team backed request that was a minimal interruption, so it's being pushed. This will be virtually obsolete after the next fork, but it will be usable from the master branch.
It is expected to be tested and approved by members of the team, and will be skipping the code review load on the dev team.