Skip to content

[RPC] add vout.n sequence number to decoderawtransaction#868

Merged
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
CaveSpectre11:getrawtx-vout
Nov 9, 2020
Merged

[RPC] add vout.n sequence number to decoderawtransaction#868
codeofalltrades merged 1 commit intoVeil-Project:masterfrom
CaveSpectre11:getrawtx-vout

Conversation

@CaveSpectre11
Copy link
Collaborator

@CaveSpectre11 CaveSpectre11 commented Nov 8, 2020

Problem

When looking at raw transactions in the block chain, the vout sequence number is not shown

Root Cause

Wasn't implemented

Solution

Implement it

Testing

Transactions now have a "vout.n" in vout sections, showing what the output sequence is [for use as input to raw transactions].

    {
      "type": "standard",
      "value": 345600.00000000,
      "valueSat": 34560000000000,
      "vout.n": 2,
      "scriptPubKey": {
        "asm": "OP_HASH160 4874bc3b94c4c85cf858670fef39d38fbe0d7b8b OP_EQUAL",
        "hex": "a9144874bc3b94c4c85cf858670fef39d38fbe0d7b8b87",
        "reqSigs": 1,
        "type": "scripthash",
        "addresses": [
          "38J8RGLetRUNEXycBMPg8oZqLt4bB9hCbt"
        ]
      }

@CaveSpectre11 CaveSpectre11 added Tag: TransactionRecords The display of transaction information Component: RPC Related to the console commands themselves. Tag: Waiting For Code Review Waiting for code review from a core developer labels Nov 8, 2020
@CaveSpectre11 CaveSpectre11 self-assigned this Nov 8, 2020
codeofalltrades
codeofalltrades approved these changes Nov 9, 2020
View reviewed changes
Copy link
Collaborator

@codeofalltrades codeofalltrades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f20b416

@codeofalltrades codeofalltrades merged commit 08c6a26 into Veil-Project:master Nov 9, 2020
@CaveSpectre11 CaveSpectre11 deleted the getrawtx-vout branch November 10, 2020 03:53
@CaveSpectre11 CaveSpectre11 added this to the v1.1.1 milestone Dec 17, 2020
@CaveSpectre11 CaveSpectre11 mentioned this pull request Jan 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codeofalltrades codeofalltrades codeofalltrades approved these changes

Assignees

@CaveSpectre11 CaveSpectre11

Labels

Component: RPC Related to the console commands themselves. Tag: TransactionRecords The display of transaction information Tag: Waiting For Code Review Waiting for code review from a core developer

Projects

None yet

Milestone

v1.1.1

Development

Successfully merging this pull request may close these issues.

2 participants

@CaveSpectre11 @codeofalltrades