Do not load corrupted duplicate block indexes.#487
Merged
presstab merged 1 commit intoVeil-Project:masterfrom Apr 11, 2019
Merged
Do not load corrupted duplicate block indexes.#487presstab merged 1 commit intoVeil-Project:masterfrom
presstab merged 1 commit intoVeil-Project:masterfrom
Conversation
presstab
added
Tag: Needs Release Notes
blondfrogs
reviewed
Apr 9, 2019
presstab
force-pushed
the
setblockindexempty
branch
from
b4687a5 to
e834c1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #405
It is also possible that #422 is related, but not positive.
For some reason multiple indexes are being saved to disk for the same block. The second index will overwrite the first index on first load. The second index has
nTxset to0, as well as all relevant block file locations. The second index causes all subsequent indexes to havenChainTxset to0, causing them not to be able to be considered block candidates. Also notable is that the second index has the wrong database key which is supposed to be the block hash but is not.This change simply ignores the second block index on first load. It is still yet to be determined what causes the duplicate index.