Skip to content

[GUI] Add a link to the "Looks like you are new here!" screen by a "?" icon in the navigation bar#1035

Merged
seanPhill merged 1 commit intoVeil-Project:masterfrom
Necrosys:fix_issue_1016
Jun 10, 2023
Merged

[GUI] Add a link to the "Looks like you are new here!" screen by a "?" icon in the navigation bar#1035
seanPhill merged 1 commit intoVeil-Project:masterfrom
Necrosys:fix_issue_1016

Conversation

@Necrosys
Copy link
Contributor

@Necrosys Necrosys commented Jun 2, 2023

Fixes #1016

Screenshots

  • New wallet, Overview page, no transactions yet
    new_wallet_overview_page_no_trx_yet
  • New wallet, Overview page, immature transaction only
    new_wallet_overview_page_immature_trx
  • New wallet, Help page
    new_wallet_help_page
  • Old wallet, Overview page
    old_wallet_overview_page
  • Old wallet, Help page
    old_wallet_help_page

Copy link
Collaborator

@ohcee ohcee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK working and looking as it should. Tested on MacOS with a balance/transactions and without balance.

@seanPhill seanPhill requested review from WetOne and seanPhill June 5, 2023 15:10
Copy link
Collaborator

@seanPhill seanPhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. More code changes than what I had envisioned, but function implementation is even more elegant than what I had in mind! :)

@seanPhill
Copy link
Collaborator

@Necrosys please supply a Veil stealth address so we can tip you for this PR (and the previous one).

@seanPhill seanPhill merged commit a8b27c6 into Veil-Project:master Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] (low priority) Add a link to the "Looks like you are new here!" screen by a "?" icon in the navigation bar?

3 participants