Issue#976 dumpwallet#1031
Merged
seanPhill merged 4 commits intoVeil-Project:masterfrom May 17, 2023
ohcee:issue#976-dumpwallet
Merged
Issue#976 dumpwallet#1031seanPhill merged 4 commits intoVeil-Project:masterfrom ohcee:issue#976-dumpwallet
seanPhill merged 4 commits intoVeil-Project:masterfrom
ohcee:issue#976-dumpwallet
Conversation
seanPhill
approved these changes
May 17, 2023
Collaborator
seanPhill
left a comment
seanPhill
left a comment
There was a problem hiding this comment.
Compared the help text for dumpprivkey and dumpwallet on an existing wallet and on this PR.
Contributor
|
Textual changes. Looks good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dumpwalletanddumpprivkeycannot be used as a backup for stealth addresses. There is no warning regarding this.Root Cause
Hasn't been added to wallet.
Solution
This PR leaves the note
Note: dumpwallet does not include private keys for stealth addresses. Use wallet.dat file or seed words for complete backup.in thehelp dumpprivkeyandhelp dumpwalletas well as the dumped.datfile.Bounty PR
#976
Bounty Payment Address
sv1qqpy56fkfmkffp44q8tjx6scldglaf5qqkwsv3lzd440z9vh6d8y9hcpqts3u7xpwt92gxsyr0n42c228n6j5cczzvrget8hhzyfrq7qydv05qqqr7s9z5
Unit Testing Results
Tested on MacOS