[Build] Allow building on later model Ubuntu/Debian#1029
Merged
seanPhill merged 2 commits intoVeil-Project:masterfrom May 1, 2023
Merged
[Build] Allow building on later model Ubuntu/Debian#1029seanPhill merged 2 commits intoVeil-Project:masterfrom
seanPhill merged 2 commits intoVeil-Project:masterfrom
Conversation
added 2 commits
April 3, 2023 02:25
avoid "undefined reference to `arc4random_addrandom'" in later libc, additionally no patching required.
./boost/thread/pthread/thread_data.hpp:60:5: error: missing binary operator before token "("
60 | #if PTHREAD_STACK_MIN > 0
| ^~~~~
Collaborator
|
I've reviewed this code and it looks good and makes sense. Furthermore the Github Actions build completed without error, and as we know, Github no longer builds with Ubuntu version 18. |
seanPhill
approved these changes
May 1, 2023
Collaborator
seanPhill
left a comment
seanPhill
left a comment
There was a problem hiding this comment.
This code appears fine and worked without error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch for libevent due to header differences in later glibc and patch for boost, to allow compilation with g++ 11