[RPC] Return RandomX seed and ProgPow epoch also if no miningaddress is set#1022
Merged
seanPhill merged 2 commits intoVeil-Project:masterfrom Dec 21, 2022
Merged
Conversation
in `getblocktemplate` rpc.
in `getblocktemplate` rpc.
us77ipis
changed the title
Zannick
approved these changes
Nov 5, 2022
Zannick
approved these changes
Nov 11, 2022
|
Wouldn't this be a bit pointless if |
Contributor
Author
|
For example a mining pool which builds the blocks from scratch needs the epoch information but not the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
getblocktemplaterpc, should always include the RandomX seed (if a RandomX template is requested) and the ProgPow epoch (if a ProgPow template is requested), also if no miningaddress was specified in the config.