Closed
Conversation
The current Throwable implementation allows for subclassing but the use of private methods prevents the subclass from overriding the methods used to handle messages from Hand.cs. Changing the definition allows the subclass the ability to override each method and still be able to call the parent classes implementation as well. It's possible to use the onPickUp or onDetachFromHand but this can be limiting.
Author
|
Bump |
keithbradner
added a commit
that referenced
this pull request
Jun 21, 2018
Changes for v1.3b06: * Added some flower and planting stuff for the tutorial * Updating knuckles actions and binding jsons * Added code solution for blending skeleton animations to mechanim, no example yet though * Updated some helper components to utilize Unity Events properly * Updated skeleton hierarchy Changes for v1.3b05: * Added a knuckles binding for the Grab mode * Fixed some bugs around skeleton updates and GC alloc * Fixed a pretty significant perf hit * Added a blending option to skeletons * Added some ui to try out skeleton options * Added a target for the throwing examples * Updated longbow to only fire arrows with the pinch action * Updated other interactable examples * Added some helper methods to hand around showing / hiding controller or the whole hand. * Fixed some of the throwing examples Changes for v1.3b04: * Added some more extensive velocity and angular velocity estimation based on positions and rotations per frame. Normalizing for time between frames. * Cleaned out and updated the actions + bindings for knuckles/wands/touch. * Fixed a bug with newly created actions not having a set type * Updated extra scenes to use the new input system Changes for v1.3b03: * Fixed some warnings for unity 2017 / 2018. * Fixed some editor UI issues for 2018 * Fixed issues with Unity 2017+ not wanting to open scenes from a script reloaded callback Changes for v1.3b02: * Added DefaultInputAction attribute to automatically assign actions during action generation. * Updated default CameraRig prefab to use the new input system and components Changes for v1.3b01: * Integrated SteamVR Input System. https://steamcommunity.com/games/250820/announcements/detail/3809361199426010680 * [InteractionSystem] Added basic examples of the Skeletal API * [InteractionSystem] Integrated SteamVR Input System. Actions and Action Sets instead of buttons. * [InteractionSystem] Added Velocity style object interaction * [InteractionSystem] Fixed some issues from github. Took some pull requests. #79 #73 #72 #71 #67 #64 #84 #78
Collaborator
|
Thanks for the PR. I believe I fixed this. Let me know in an issue if I didn't make enough virtual / protected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Throwable implementation allows for subclassing but the use of private methods prevents the subclass from overriding the methods used to handle messages from Hand.cs. Changing the definition allows the subclass the ability to override each method and still be able to call the parent classes implementation as well. It's possible to use the onPickUp or onDetachFromHand but this can be limiting.