WaylandBackend: fix crash when switching TTYs #1919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
ab24255 to
52ed746
Compare
Author
|
improved the commit message by mentioning the function where the crash occurs. |
Author
|
@misyltoad / @lostgoat, could someone of you take a look at this? It's a ~1line change (a single early return / null ptr check) and does not have any impact on use when not switching TTYs. |
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
52ed746 to
a28ca7a
Compare
This can happen when the seat loses pointer capability, such as when switching to another TTY on Sway.
Ferdi265
force-pushed
the
fix-null-wl-pointer-crash
branch
from
a28ca7a to
7c072d7
Compare
Author
|
rebased onto latest master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in
UpdateCursor()that occurs when switching TTYs due to m_pPointer (awl_pointer*) being null.This can happen when the seat loses pointer capability, such as when switching to another TTY on Sway.
The fix is just to ignore the cursor update with an early return when there is no
wl_pointer, same asSetRelativeMouseMode()already does.This PR makes it possible to use screen lockers that switch TTY or use multiple sessions on different TTYs while gamescope is active without the whole gamescope session crashing.
Fixes #1920.