WaylandBackend: allow gamescope to run under vulkan #1826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue for me. |
13 tasks
|
Confirmed works flawlessly on my system as well. Can we get a merge PR? |
6 tasks
|
Not sure this PR is entirely correct. At least under wlroots with the Vulkan backend, absolutely no formats report support for the INVALID modifier, only a bunch of tiled formats and LINEAR. |
Author
|
The original code is nonsense to begin with. To see if a format is supported you have to intersect what your upstream can produce with what your downstream can consume. The goal of this PR was only to enable additional case that were previously definitely broken, therefore doing no harm. But gamescope seems unmaintained at this point. |
emersion
reviewed
Oct 4, 2025
emersion
reviewed
Oct 4, 2025
The invalid modifier is not supported under vulkan, so fall back to any other modifier if a format does not support the invalid modifier. Closes ValveSoftware#1604
mahkoh
force-pushed
the
jorth/vulkan-support
branch
from
5266372 to
b6a38fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The invalid modifier is not supported under vulkan, so fall back to any other modifier if a format does not support the invalid modifier.
Closes #1604