fix: keep @agent first send on target workspace Prevent reactive ACP loads from cancelling new-agent prompts by binding the target workspace on session switch and creating the target main session when missing.#1184
Conversation
…loads from cancelling new-agent prompts by binding the target workspace on session switch and creating the target main session when missing.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6179cce596
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| })); | ||
| if (targetAgent) { | ||
| selectAcpSession(sessionKey); | ||
| selectAcpSession(sessionKey, promptCwd); |
There was a problem hiding this comment.
When the first targeted send is for an agent whose session is not in sessions, this call switches to a newly inserted placeholder before the async load runs. If that loadAcpSession(...createIfMissing) fails transiently before creating the ACP session, the next retry renders with the placeholder present but not marked createdLocally, so createIfMissing becomes false and the retry tries to load a non-existent session instead of creating it. Keep the placeholder pending/local until the create load succeeds, or otherwise remember that this target still needs creation.
Useful? React with 👍 / 👎.
| "gatewayStatus": "gateway {{state}} | port: {{port}} | pid: {{pid}}", | ||
| "retryFailedAttachments": "Retry failed attachments", | ||
| "workspacePrefix": "{{workspace}}", | ||
| "workspacePrefix": "Workspace: {{workspace}}", |
There was a problem hiding this comment.
The repo instructions require full locale coverage for user-facing text under en/zh/ja/ru. This changes the composer workspace label in three locales, but shared/i18n/locales/ru/chat.json still has the old "{{workspace}}" value, so Russian users will not see the added workspace prefix and the locale set is inconsistent.
Useful? React with 👍 / 👎.
1 participant
No description provided.