Skip to content

Revert "fix: raise default LLM idle timeout to 240 seconds to reduce false timeouts on slow providers"#1172

Merged
vcfgv merged 1 commit into
mainfrom
revert-1170-feat/add_default_timeout
Jul 16, 2026
Merged

Revert "fix: raise default LLM idle timeout to 240 seconds to reduce false timeouts on slow providers"#1172
vcfgv merged 1 commit into
mainfrom
revert-1170-feat/add_default_timeout

Conversation

@vcfgv

@vcfgv vcfgv commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Reverts #1170

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d4539ba583

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/stores/chat.ts
/** OpenClaw LLM idle timeout before an internal retry. */
const LLM_IDLE_HINT_MS = 120_000;
/** Wait past one LLM idle window before declaring a hard no-response failure. */
const NO_RESPONSE_SAFETY_TIMEOUT_MS = 130_000;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow the retried model call to finish before failing

When a provider stays silent until OpenClaw's 120s LLM idle watchdog, the code above says OpenClaw starts an internal retry at that boundary, but this hard failure fires at 130s. That gives the retry only ~10 seconds to produce streamed output, so slow providers or first-token delays after the retry will be marked as “No response received”, clear sending, and stop the fallback history poll even though the runtime may still complete shortly afterward. Please keep the no-response timeout at least one full retry window past the idle hint.

Useful? React with 👍 / 👎.

@vcfgv
vcfgv merged commit 7774d89 into main Jul 16, 2026
6 checks passed
@vcfgv
vcfgv deleted the revert-1170-feat/add_default_timeout branch July 16, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant