Conversation
# Conflicts: # shared/i18n/locales/en/chat.json # shared/i18n/locales/ja/chat.json # shared/i18n/locales/ru/chat.json # shared/i18n/locales/zh/chat.json # src/pages/Chat/index.tsx
fix: avoid workspace-triggered chat history fanout # Conflicts: # tests/e2e/chat-acp-inline-timeline.spec.ts feat: refine workspace session UI
…ACP from session title
fix(chat): restore ACP question directory fix(chat): cap question directory titles fix(chat): improve question directory accessibility fix(chat): refine question directory navigation fix(chat): preserve question title graphemes
docs: add ACP file activity implementation plan feat(chat): project OpenClaw file activities feat(files): add workspace-scoped file access fix(files): harden workspace-scoped access feat(preview): scope tool-derived file access fix(preview): key scoped loads by workspace feat(chat): restore ACP file activity UI fix(chat): allow focused changes to collapse fix(chat): key change navigation by invocation fix(chat): keep file projection renderer-safe test(chat): cover ACP file activity flow test(chat): address file activity review test(chat): snapshot live ACP generation fix(harness): run profile commands from repository root test(sidebar): match generic load more label test(chat): fix ACP prompt E2E baseline docs(chat): explain ACP file activity semantics fix(files): remove scoped shell actions docs: align scoped preview plan docs: clarify scoped preview boundary
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7a1c13d58
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await sendAcpPrompt({ | ||
| sessionKey, | ||
| cwd: promptCwd, | ||
| message: text, | ||
| media, |
There was a problem hiding this comment.
When this ACP prompt path succeeds for a locally-created New Chat, the code only acknowledges the backing ACP session; it never updates sessionLabels/last activity the way the legacy send path did. In that scenario the sidebar keeps showing the raw agent:...:session-* key and stale ordering until some later manual/session refresh. Please hydrate the label/activity from the sent text or trigger a session-summary refresh after the prompt succeeds.
Useful? React with 👍 / 👎.
| this.loadedSessionKey = null; | ||
| this.loadedAcpSessionId = null; |
There was a problem hiding this comment.
When the ACP child exits while a session is open, this clears only the loaded ACP session fields. The renderer still believes the same active session/cwd is loaded, so the Chat reload guard stays false; the next send reaches sendPrompt and fails with ACP session is not loaded instead of reconnecting and reloading. Clear active session state and notify the renderer, or make the next prompt path reload the active session after reconnect.
Useful? React with 👍 / 👎.
|
LGTM |
2 participants
Summary
Related Issue(s)
N/A
Type of Change
Validation
Checklist